Can't figure out what's wrong? Please Help?

[katielynnsdad]

I have been trying for 3 days now to figure out what is wrong with this code, Can anyone clue me in please?

Public Function CalcAverage(ByVal average As Decimal, ByVal total As Decimal) As Decimal


count = count + 1

'calculate average if count is greater than zero
If count > 0 Then

average = total / count

End If

Return average

End Function

Thank you very much for any help!

[katielynnsdad]

Sorry!

[dragul]

I think the "Return average" line should be inside the if other wise its trying to do it if the calculation is being done which may be causing the fault:

'///////////////////////////////////////////////
Public Function CalcAverage(ByVal average As Decimal, ByVal total As Decimal) As Decimal

count = count + 1

'calculate average if count is greater than zero
If count > 0 Then

average = total / count

Return average

End If

End Function
'/////////////////////////////

try that

[aklwer3456]

Decimal is not VB data type. Try DOUBLE instead (if you mean floating point).

or INTEGER, if you mean whole integer,
or LONG--> same but range is bigger

And the logic of your function is not clear. What do you want to accomplish?

Public Function CalcAverage(ByVal average As Double, _
ByVal total As Double) As Double

count = count + 1
'calculate average if count is greater than zero
If count > 0 Then
average = total / count

'instead of Return average
CalcAverage= average
End If
End Function

[katielynnsdad]

The CalcAvg() is a function returning the average rain fall to the calc button code. In the program you enter the amount of rainfall and it calculates the total rain and the average rain, every time you enter an amount.
Also, the function is supposed to be Private instead of public.
It uses 2 functions to calculate the total and the average.
Thank you all for your help!