onclick not working

[michaelgriffin]

Hi,

I am using this code to call a function. As soon as I insert the reference in the function it stops working. This is being called via AJAX request.

This works:

Code: Select all

$output .= "
    <td width='20%' nowrap='nowrap' class='results_column'><div align='center'><img src='$_ENV[home_www]/icon/delete.png' title='Delete User' onclick='javascript:deleteNow(])' style='cursor:pointer' width='16' /></div></td>
    ";

When adding the reference it stops working

Code: Select all

$output .= "
    <td width='20%' nowrap='nowrap' class='results_column'><div align='center'><img src='$_ENV[home_www]/icon/delete.png' title='Delete User' onclick='javascript:deleteNow($users[reference])' style='cursor:pointer' width='16' /></div></td>
    ";

Any help would be greatly appreciated!

[webmaster]

There's a problem when adding one variable in another.

I quess it's PHP your using. There are two methods I use (might be more).

1. $variable = "Text text {$foo} text text!";
2. $variable . "Text text " . $foo . " text text!";



So, try this:

Code: Select all

$output .= "
    <td width='20%' nowrap='nowrap' class='results_column'><div align='center'><img src='$_ENV[home_www]/icon/delete.png' title='Delete User' onclick='javascript:deleteNow({$users[reference]})' style='cursor:pointer' width='16' /></div></td>
    ";

[HotNoob]

you can also use single quotes instead of double quotes; infact i recomend that you use single quotes since it uses a lot less processing time, and reduces the number of script vulnerabilities.

Code: Select all

   
<?php
$output .= '
        <td width=\'20%\' nowrap=\'nowrap\' class=\'results_column\'>
            <div align=\'center\'>
                <img src=\''.$_ENV[home_www]/icon/delete.png.'\' title=\'Delete User\' onclick=\'javascript:deleteNow("'.$users[reference].'")\' style=\'cursor:pointer\' width=\'16\' />
            </div>
        </td>
        ';
?>

also, i belive that your problem was the lack of qoutes in the input, unless $users[reference] referes to the name of a variable.

well, i hope one of the solutions provided in this topic works for you.

[michaelgriffin]

thanks hotNoob! problem solved!