yet another code

[Phate]

Malcom!!!(or anyone) I need your help again!

I need of another code....

I want for the people that visit site to be able to upload a file, add a description of the file, and browse all of the files that have been uploaded.

Is there a way for me to do that?

[Malcolm]

Here's your quick code, note that most PHP/Apache configs only allow 2mb files to be uploaded and with this script people can upload anything to pretty much anywhere if they know how to mess with file names:

Code: Select all

Upload a file!<br />
<form method='post' action='?post=TRUE' enctype='multipart/form-data'>
<input type="file" name="file" /><br />
<input type='submit' />
</form>
<br />
<hr />

<?php
$dir = "uploads";
function read_dir($dir)
{
   $list = array();
   if (is_dir($dir)) {
      if ($handle = opendir($dir)) {
         while (false !== ($file = readdir($handle))) {
            if ($file != "." && $file != "..") {
                  $list[] = $dir."/".$file;
            }
         }
      }
      closedir($handle);
   }

   return $list;
}

if(isset($_GET['post'])){
   if(copy($_FILES['file']['tmp_name'], $dir."/".$_FILES['file']['name'])){
      echo "Upload Success!<hr /><br />";
   }else{
      echo "Error on upload!<hr /><br />";   
   }
}

?>
Files:<br />
<?php
$list = read_dir($dir);
foreach($list as $key => $val){
   echo $key.": <a href='".$val."'>".$val."</a><br />\n";
}
?>


[Phate]

1 more thing....
Is there any way to limit the upload to a certian extension? (like . exe)

[Malcolm]

replace:

Code: Select all

if(isset($_GET['post'])){
   if(copy($_FILES['file']['tmp_name'], $dir."/".$_FILES['file']['name'])){
      echo "Upload Success!<hr /><br />";
   }else{
      echo "Error on upload!<hr /><br />";   
   }
}


with this:

Code: Select all

$exts = array('mp3', 'txt', 'mpeg');
if(isset($_GET['post'])){
   $f_ext = split(".", $_FILES['file']['tmp_name']);
   $f_ext = $f_ext[sizeof($f_ext)-1];
   if(in_array($f_ext, $exts)){
      if(copy($_FILES['file']['tmp_name'], $dir."/".$_FILES['file']['name'])){
         echo "Upload Success!<hr /><br />";
      }else{
         echo "Error on upload!<hr /><br />";   
      }
   }else{
      echo "Invalid file.<br />";
   }
}


[Phate]

awesome!!
thanks man!


edit:::

once i made it and uploaded it, i get a 500 error when i try and view it. Any suggestions?
it is located at http://zbrooks.com/upload.php

[webmaster]

Try another server if you can.

[Malcolm]

Looks like the PHP install you have on there may have a problem. The code was tested on my home server (Linux Apache 1.3/PHP 4) and worked fine, though looks very ugly

[Phate]

I am a big noob with PHP... is there any more code i need to add for it to work?

[Malcolm]

My bad, there were some logic errors in there:

Code: Select all

Upload a file!<br />
<form method='post' action='?post=TRUE' enctype='multipart/form-data'>
<input type="file" name="file" /><br />
<input type='submit' />
</form>
<br />
<hr />

<?php
$dir = "uploads";
function read_dir($dir)
{
   $list = array();
   if (is_dir($dir)) {
      if ($handle = opendir($dir)) {
         while (false !== ($file = readdir($handle))) {
            if ($file != "." && $file != "..") {
                  $list[] = $dir."/".$file;
            }
         }
      }
      closedir($handle);
   }

   return $list;
}

$exts = array('mp3', 'txt', 'mpeg');
if(isset($_GET['post'])){
   $f_ext = split("\.", $_FILES['file']['name']);
   $f_ext = $f_ext[sizeof($f_ext)-1];
   echo "<hr />* ".$f_ext."*<hr />";
   if(in_array($f_ext, $exts)){
      if(copy($_FILES['file']['tmp_name'], $dir."/".$_FILES['file']['name'])){
         echo "Upload Success!<hr /><br />";
      }else{
         echo "Error on upload!<hr /><br />";   
      }
   }else{
      echo "Invalid file.<br />";
   }
}

?>
Files:<br />
<?php
$list = read_dir($dir);
foreach($list as $key => $val){
   echo $key.": <a href='".$val."'>".$val."</a><br />\n";
}
?>


[Phate]

I am still gettting a 500 error.... any other possibilities of what could be going wrong?